Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Plots and Pie Charts for Every Theme #33

Open
BattleCh1cken opened this issue Mar 7, 2024 · 0 comments
Open

✨ Plots and Pie Charts for Every Theme #33

BattleCh1cken opened this issue Mar 7, 2024 · 0 comments
Labels
type:enhancement New feature or request

Comments

@BattleCh1cken
Copy link
Contributor

Requested Feature

I propose that we add plots and pie charts to the other themes, in order to have them match the functionality of the Radial theme

Current Implementation

Currently only the Radial theme supports plots and pie charts. It wraps the CeTZ plotting API to make it less verbose, and customize it to look nice.

Motivation

It would be nice to have this functionality in all of the themes, as these tools are really useful to have natively.

(Optional) Possible Implementations and Alternatives

Right now the major obstacle is that we haven't found a way to reduce code duplication while implementing these new components. The decision matrices already suffer from this problem, and they abstract all of their calculations away to a helper function.

An approach we could take is to only change the colors between themes. This means that we could provide a generic plot and pie chart component, and then have a colors parameter, which each theme could override, and present as a component.

@BattleCh1cken BattleCh1cken added the type:enhancement New feature or request label Mar 7, 2024
@BattleCh1cken BattleCh1cken changed the title [FEATURE] Plots and Pie Charts for Every Theme ✨ Plots and Pie Charts for Every Theme Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant