Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Failing gallery builds do not cause the ci to fail #46

Closed
BattleCh1cken opened this issue May 21, 2024 · 2 comments
Closed

🐛 Failing gallery builds do not cause the ci to fail #46

BattleCh1cken opened this issue May 21, 2024 · 2 comments
Labels
repro:confirmed type:bug Something isn't working

Comments

@BattleCh1cken
Copy link
Contributor

See title. Currently the gallery build is acting as a form of integration testing for the project, so having this report errors correctly is extremely important.
@BattleCh1cken
Copy link
Contributor Author

Here's an example:
https://github.com/The-Notebookinator/notebookinator/actions/runs/9167968659/job/25205979953

@BattleCh1cken
Copy link
Contributor Author

Fixed by #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
repro:confirmed type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BattleCh1cken