Skip to content

Commit

Permalink
chore: use M_PI instead of PI parameter (#2747)
Browse files Browse the repository at this point in the history
* changed PI variable value from 3.14 to M_PI

* changed PI variable to M_PI

* changed the degree_to_radians function

* comments removed

* docs: remove pi param

* fix: typo in function name

* changed degree to degrees

---------

Co-authored-by: [Divyansh Jain] <[[email protected]]>
Co-authored-by: realstealthninja <[email protected]>
  • Loading branch information
3 people authored Oct 4, 2024
1 parent 901f231 commit c56496d
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions physics/ground_to_ground_projectile_motion.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
*/

#include <cassert> /// for assert()
#define _USE_MATH_DEFINES
#include <cmath> /// for std::pow(), std::sin(), and std::cos()
#include <iostream> /// for IO operations

Expand All @@ -27,11 +28,12 @@ namespace ground_to_ground_projectile_motion {
/**
* @brief Convert radians to degrees
* @param radian Angle in radians
* @param PI The definition of the constant PI
* @returns Angle in degrees
*/
double degrees_to_radians(double radian, double PI = 3.14) {
return (radian * (PI / 180));

double degrees_to_radians(double degrees){
double radians = degrees * (M_PI / 180);
return radians;
}

/**
Expand Down

0 comments on commit c56496d

Please sign in to comment.