Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Foundations/Git Basics: GitHub links are broken #24300

Closed
2 of 3 tasks
notmyf4ulty opened this issue Jun 26, 2022 · 6 comments
Closed
2 of 3 tasks

Bug - Foundations/Git Basics: GitHub links are broken #24300

notmyf4ulty opened this issue Jun 26, 2022 · 6 comments
Labels
Type: Bug Involves something that isn't working as intended

Comments

@notmyf4ulty
Copy link

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this issue follows the Bug - location of bug: brief description of bug format, e.g. Bug - React section: Knowledge Checks don't link to resource

The following checkbox is OPTIONAL:

  • I would like to be assigned this issue to work on it

1. Description of the Bug:

Introduction to Git or Git Basics lesson links in the README.md from the foundations directory do not work.

2. How To Reproduce:

When in the foundations directory, clicking either Introduction to Git or Git Basics will result with Page Not Found error: The 'TheOdinProject/curriculum' repository doesn't contain the 'foundations/git_basics/introduction_to_git.md' path in 'main'.

3. Expected Behavior:

Links working properly.

4. Desktop/Device:

--

5. Additional Information:

I ran a global search in the curriculum repo for some phrases from these two lessons, but didn't get any results. I see some other issues around these topics and I suppose that someone, instead of moving the lessons to fit a proper structure, by mistake removed them entirely.

@notmyf4ulty notmyf4ulty added Status: Needs Review Type: Bug Involves something that isn't working as intended labels Jun 26, 2022
@sh3i1a
Copy link
Contributor

sh3i1a commented Jun 26, 2022

Hi, it looks like the entire Git Basics directory is missing. I'm available to work on it to create the directory and the MD files.

@dm-murphy
Copy link
Member

Good catch, thanks for bringing this up @notmyf4ulty! 🙏

@01zulfi Is this included in your curriculum repo cleanup?

The README hasn't been updated since February and is missing the Commit Messages lesson under HTML Foundations too.

@sheilaJava 👋 Thanks so much for volunteering. Just waiting to find out more on the status of this issue and will get back to you!

@01zulfi
Copy link
Member

01zulfi commented Jun 28, 2022

The Git Basics lesson can be found in the curriculum/git directory. We moved all the git lessons to this directly except for the "Setting Up Git" lesson.

The Foundations README is outdated, this should be fixed whenever I have a chance to get around to conforming the foundations directory to the Suggested Implementation in this issue.

@dm-murphy
Copy link
Member

The Git Basics lesson can be found in the curriculum/git directory. We moved all the git lessons to this directly except for the "Setting Up Git" lesson.

The Foundations README is outdated, this should be fixed whenever I have a chance to get around to conforming the foundations directory to the Suggested Implementation in this issue.

Thanks for clarifying @01zulfi 🙏

If you are looking for any community contributors to help you on this when the time comes, please consider reaching out to @sheilaJava

@01zulfi We can either close this issue out now if it's covered by your on-going project or leave this issue open as a reminder. Whatever works best for you, thanks!

@01zulfi
Copy link
Member

01zulfi commented Jun 29, 2022

@dm-murphy I don't see a reason to keep this issue open.

@dm-murphy
Copy link
Member

@notmyf4ulty Closing out the issue per the above conversation. Thanks again for bringing this up! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Involves something that isn't working as intended
Projects
None yet
Development

No branches or pull requests

4 participants