Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Ruby : Add missing lessons exercises #107

Closed
2 of 7 tasks
ghost opened this issue Sep 11, 2024 · 1 comment
Closed
2 of 7 tasks

Basic Ruby : Add missing lessons exercises #107

ghost opened this issue Sep 11, 2024 · 1 comment
Labels
Status: Needs Review This issue/PR needs an initial or additional review

Comments

@ghost
Copy link

ghost commented Sep 11, 2024

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this issue follows the location for request: brief description of request format, e.g. Exercises: Add exercise on XYZ

The following checkbox is OPTIONAL:

  • I would like to be assigned this issue to work on it

1. Description of the Feature Request:

Currently there are not any exercises for the lessons:

  1. Variables
  2. Input and Output
  3. Conditional Logic
  4. Loops

Leaving a gap between 1_data_types and 6_arrays. I know learners are encouraged to use replit, experiment and that some resources like the ones at launchschool have some small exercises, but I think that having multiple exercises with tests could improve the experience for learners and make them more comfortable using their own environment rather than replit or irb.

I know that currently there are multiple issues (#37, #9, #8, #7) that were meant to take care of this, but those are from years ago and I preferred creating a new one rather than bumping each one of them. Also note that one of those is meant to add exercises for the blocks lesson in the "advanced ruby" course.

I saw that these issues were part of a project in which they were moved to the "backlog" and I don't know if there was a reason for that or to not add these exercises.

2. Acceptance Criteria:

  • Add exercises with tests for the variables lesson.
  • Add exercises with tests for the input and output lesson.
  • Add exercises with tests for the conditional logic lesson.
  • Add exercises with tests for the loops lesson.

3. Additional Information:

I am willing to work in the making of some of these exercises if needed.

@ghost ghost added the Status: Needs Review This issue/PR needs an initial or additional review label Sep 11, 2024
@ghost ghost changed the title Ruby Course : Add missing lessons exercises Basic Ruby : Add missing lessons exercises Sep 11, 2024
@rlmoser99
Copy link
Member

Thank you for taking the time to make an issue. However, as you have noted there are already issues that exist for input and output, conditional logic, and loops. We previously closed the issue that we created for the variables lesson.
#6

Instead of combining multiple new exercises into one issue, we prefer to keep them separate. The only time that we like to combine multiple tasks into 1 issue, is when we are making small changes, like consistent headings, knowledge checks, etc to multiple lessons. In addition, each issue has additional details, so I am going to close this combined issue.

If you want to choose one of the open issues to create those exercises, you are welcome to comment on one of them to be assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This issue/PR needs an initial or additional review
Projects
None yet
Development

No branches or pull requests

1 participant