Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix and improve error reporting #4740

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

KevinMulhern
Copy link
Member

Because:

  • Browser errors were not being reported
  • Sentry has new performance profiling features we are

This commit:

  • Load sentry browser from a CDN so it is loaded and available to report any errors before the rest of our JS
  • Adds a revision initializer so we can attach the specific release to Sentry errors.
  • Enable profile for the Sentry Ruby SDK

@KevinMulhern KevinMulhern force-pushed the chore/improve-error-reporting branch from 98d1a6a to 9f622e5 Compare August 10, 2024 10:53
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4740 August 10, 2024 11:02 Inactive
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4740 August 10, 2024 11:19 Inactive
Because:
- Browser errors were not being reported
- Sentry has new performance profiling features we are

This commit:
- Load sentry browser from a CDN so it is loaded and available to report any errors  before the rest of our JS
- Adds a revision initializer so we can attach the specific release to Sentry errors.
- Enable profile for the Sentry Ruby SDK.
@KevinMulhern KevinMulhern force-pushed the chore/improve-error-reporting branch from 9f622e5 to d72a890 Compare August 10, 2024 11:20
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4740 August 10, 2024 11:20 Inactive
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4740 August 10, 2024 11:28 Inactive
@KevinMulhern KevinMulhern marked this pull request as ready for review August 10, 2024 11:44
@KevinMulhern KevinMulhern merged commit 64cfc2b into main Aug 10, 2024
2 checks passed
@KevinMulhern KevinMulhern deleted the chore/improve-error-reporting branch August 10, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant