Skip to content
This repository has been archived by the owner on Oct 20, 2024. It is now read-only.

Prioritize primary meaning #8

Open
Jmaher16 opened this issue Apr 21, 2021 · 3 comments
Open

Prioritize primary meaning #8

Jmaher16 opened this issue Apr 21, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@Jmaher16
Copy link

Would it be possible to have it prioritize using the primary meaning over an alternative. An example of this is for "friend" it currently shows "味方” instead of "友達

@ThePieMonster
Copy link
Owner

Definitely possible.
The extension would need another Dictionary created containing these items (that the community would have to agree on), and then override the main dictionary afterwards.

For now, you could do something like the below:
image

@ThePieMonster ThePieMonster added the enhancement New feature or request label Apr 21, 2021
@Jmaher16
Copy link
Author

not sure if it is something you can pull through the API, but WK identifies Primary/Alternative on their vocab pages.

@domi2120
Copy link
Contributor

domi2120 commented Apr 30, 2021

Its possible but it would require quite a bit of rewriting of how the replacement logic interacts with the vocab. Currently its a simple dictionary (which already shows issues on synonyms like, 私, 僕 and 我). To fix it the dictionary would likely need to be replaced with a structure similar to "key: { primary: [] , secondary: [] }", possibly with some options to randomize primaries / secondaries or both. Due to this being a pretty fundamental structure change, it will also require some tweaking of the custom vocab imports via. google sheets and the options page. (this would also quite certainly have a pretty negative impact on performance)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants