Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS IoT #146

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Support AWS IoT #146

wants to merge 5 commits into from

Conversation

happyRip
Copy link
Member

@happyRip happyRip commented Nov 14, 2024

Summary

Closes #143

Changes

Main:
  • Add awsiot source
Other:
  • Rename all source command variables to Command.
    • e.g. awsiot.Command instead of awsiot.AWSIoTCmd
  • Define util.Unmarshaller interface that was not defined previously.

Testing

Tested by migrating a device without session from AWSIoT to TTS.

Need to test migration with session and an actual device.

Regressions

...

Notes for Reviewers

At the moment there are docstrings, readme and changelog entry missing. They will be added but the code can be reviewed at this point without them.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.

@happyRip happyRip added this to the Nov 2024 milestone Nov 14, 2024
@happyRip happyRip self-assigned this Nov 14, 2024
@happyRip happyRip force-pushed the feature/aws-iot branch 3 times, most recently from 628b361 to 7786d85 Compare November 14, 2024 09:37
@happyRip happyRip marked this pull request as ready for review November 14, 2024 09:43
@happyRip happyRip force-pushed the feature/aws-iot branch 2 times, most recently from d7ae64c to ba6e5ba Compare November 14, 2024 09:47
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support migration from AWS IoT
2 participants