Picture in Picture on Android - We need your help! #4228
Replies: 8 comments 2 replies
-
Thanks. @KrzysztofMoch Bare React Native
<activity
android:name=".MainActivity"
...
android:supportsPictureInPicture="true"> Expo
"plugins": [
[
"react-native-video",
{
"enableAndroidPictureInPicture": true,
}
]
] |
Beta Was this translation helpful? Give feedback.
-
I'd be happy to implement it in a Streamyfin beta version and let our Android users test it. Can't wait for the release of this feature! |
Beta Was this translation helpful? Give feedback.
-
For me the code looks good, The PR is good to me, 2 comments on my side: |
Beta Was this translation helpful? Give feedback.
-
I've added that config to expo plugin in commit below. @KrzysztofMoch Can you please create a new version with above commit? |
Beta Was this translation helpful? Give feedback.
-
I tried this feature in my app and its working perfectly. Keep up the good work. Just make sure guys put android:supportsPictureInPicture="true" under activity not under application in AndroidManifest.xml and this works like charm. |
Beta Was this translation helpful? Give feedback.
-
I think it's working fine. <activity
android:name=".MainActivity"
...
android:supportsPictureInPicture="true"> |
Beta Was this translation helpful? Give feedback.
-
Hello @KrzysztofMoch, sorry for my English, I'm trying to replicate that functionality in IOS, but the enterPictureInPictureOnLeave property doesn't work when the app enters in background mode (Only for iOS, in android works good), im using the same example from this post, also im using emulators to test my app. |
Beta Was this translation helpful? Give feedback.
-
We've been using Using Expo@51 with [
"react-native-video",
{
"enableBackgroundAudio": true,
"enableNotificationControls": true,
"enableAndroidPictureInPicture": true
}
] |
Beta Was this translation helpful? Give feedback.
-
Hello everyone! 👋
We are announcing that we are starting process to merge PR made by @YangJonghun that introduce Picture in Picture on Android! We delayed the merge of this PR because it was big and risky to merge - but now we are gathering testers who will help us test and make sure everything works properly.
There is special test release
6.7.0-rc.0
that contain changes from this PRIf you are interested in bringing this feature to live help us by simply testing it. Install test release in your app or new app and test Picture in Picture.
We need to test prop
enterPictureInPictureOnLeave
, callbackonPictureInPictureStatusChanged
and component ref functionsenterPictureInPicture
andexitPictureInPicture
, Both on Android and iOS. But testing other things can also help!For android configuration see this comment - #4228 (comment)
Sample component for testing
If you had Error or you were successful to use it leave here a comment with your feedback.
After we collect enough feedback and make any potential corrections we will publish a stable version with this feature. But first we need to collect feedback from testers - and here we are counting on you!
Thank You All!
Beta Was this translation helpful? Give feedback.
All reactions