[BUG]: Memory leak in RCTView

[Varuzh1]

Version

6.7.0

What platforms are you having the problem on?

iOS

System Version

18

On what device are you experiencing the issue?

Real device

Architecture

Old architecture

What happened?

RCTVideo has a memory leak due to two retain cycles:

1. _imaAdsManager = RCTIMAAdsManager(video: self, pipEnabled: isPipEnabled) isPipEnabled closure should be called on weak self

+_imaAdsManager = RCTIMAAdsManager(video: self, pipEnabled: {[weak self] in
+            return self?.isPipEnabled() ?? false
+        })

2. ReactNativeVideoManager’s registerView method in the shared instance strongly retains RCTVideo instances without using them. Please clean up this unused functionality to avoid unnecessary memory retention.

Reproduction Link

repository link

Reproduction

Step to reproduce this bug are: Unmount any video component and verify that the deinit function in RCTVideo is not being called.

[github-actions]

Thank you for your issue report. Please note that the following information is missing or incomplete:

• reproduction link

Please update your issue with this information to help us address it more effectively.

Note: issues without complete information have a lower priority

[github-actions]

This issue is stale because it has been open for 30 days with no activity. If there won't be any activity in the next 14 days, this issue will be closed automatically.

[ng-ha]

@Varuzh1 I have the same issue. Do you have any solutions?

[freeboub]

@Varuzh1 can you please open a pr with your changes, I would be happy to review it quickly!

[ng-ha]

I tried the code you provided, but it didn’t work:

+_imaAdsManager = RCTIMAAdsManager(video: self, pipEnabled: {[weak self] in
+            return self?.isPipEnabled() ?? false
+        })

I’m facing a serious issue where the device (IOS) heats up after watching videos multiple times. The reason seems to be that the memory isn’t released properly. Can you take a look at this issue, @freeboub ? I would really appreciate it.