Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add Native Fullscreen rendering to <Video /> Component #4298

Open
gmantuanrosa opened this issue Nov 22, 2024 · 2 comments
Open
Labels

Comments

@gmantuanrosa
Copy link

Description

I have a very specific scenario for my Brownfield app but encountered other developers that share the same implementation limitation -- not specific for this library, but more common to use React Native in a brownfield app -- and I would like to propose something for this library -- that I don't know if is possible yet -- that is to run the

Why it is needed ?

I was developing a chat message feature to my native Android/iOS app and the decision was to implement using React Native, sharing the implementation details between different platforms.

The App is fully Native and a section of it would be to implement this feature, as we have some native bottom navigation, the best solution would be to implement them inside an Android Fragment or iOS Container. Because of that we had some limitations as to implement Navigation, Bottom Sheets and other features so we looked at react native libraries that are rendered in the Native Realm and not in the React Root View, for instance, react-native-true-sheet is an example where the bottom sheet gets rendered in the Native, bypassing the Fragment/Container giving the impression of a native component. This doesn't happen with react-native-bottom-sheet as it only gets rendered inside the fragment that is the RootView.

The same happened when we got to implement the Video Playback feature from a video message, react-native-video renders on the RootView creating a bad experience since only the Fragment would be displaying the video and not the entire phone screen.

So the Idea would be to render the Video component in the Native realm bypassing cases where React Native is running inside a Fragment/Container. This would imply the possibility to pass a header-like component to close the screen, or use the phone navigation gesture/button, but adding the possibility to customize it would be nice.

Possible implementation

No response

Code sample

No response

Copy link

Thank you for your feature request. We will review it and get back to you if we need more information.

@moskalakamil
Copy link
Member

Hey @gmantuanrosa, that's right, react-native-bottom-sheet can't behave as you described because it's a JavaScript library without a native module. I just reviewed the Android implementation for react-native-video, and it seems possible to achieve this behavior. I haven't checked the iOS implementation yet. This is a rather uncommon use case, so we won't prioritize this feature at the moment. However, if you'd like to speed up this process, feel free to reach out to us for commercial support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants