From 965bc4c316e710bf99fd15c6d9e629d14e93c97b Mon Sep 17 00:00:00 2001 From: Thibaut Rousseau Date: Mon, 30 Dec 2024 18:21:48 +0100 Subject: [PATCH] reactivate mssql tests The `go:debug x509negativeserial=1` fixes the certificate issue with the mssql server image See: https://github.com/microsoft/mssql-docker/issues/895 --- tests/sqlx/transactor_integration_test.go | 3 +-- tests/stdlib/transactor_integration_test.go | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/sqlx/transactor_integration_test.go b/tests/sqlx/transactor_integration_test.go index e4abcc9..e23bd18 100644 --- a/tests/sqlx/transactor_integration_test.go +++ b/tests/sqlx/transactor_integration_test.go @@ -1,3 +1,4 @@ +//go:debug x509negativeserial=1 package sqlx_test import ( @@ -720,8 +721,6 @@ func TestIntegrationTransactorOracle(t *testing.T) { func TestIntegrationTransactorMSSQL(t *testing.T) { t.Parallel() - t.Skip("Waiting for this issue to be fixed: https://github.com/microsoft/mssql-docker/issues/895") - ctx := context.Background() testcontainers.DefaultLoggingHook = func(_ testcontainers.Logging) testcontainers.ContainerLifecycleHooks { diff --git a/tests/stdlib/transactor_integration_test.go b/tests/stdlib/transactor_integration_test.go index f4d4206..b8751af 100644 --- a/tests/stdlib/transactor_integration_test.go +++ b/tests/stdlib/transactor_integration_test.go @@ -1,3 +1,4 @@ +//go:debug x509negativeserial=1 package stdlib_test import ( @@ -720,8 +721,6 @@ func TestIntegrationTransactorOracle(t *testing.T) { func TestIntegrationTransactorMSSQL(t *testing.T) { t.Parallel() - t.Skip("Waiting for this issue to be fixed: https://github.com/microsoft/mssql-docker/issues/895") - ctx := context.Background() testcontainers.DefaultLoggingHook = func(_ testcontainers.Logging) testcontainers.ContainerLifecycleHooks {