Upgrade to 4.4.x

[gannebamm]

With everything (almost) in place, I would like to test upgrading the base GeoNode to 4.4.x branch.

Furthermore, a brief documentation how to upgrade the base GeoNode version shall be given. Where to change what to set the new codebase in place.

[ridoo]

• Subtaks: Align thuenen_atlas with blueprint (no shared history at the moment)
• Subtask: Merge Thuenen-GeoNode-Development/geonode with upstream 4.4.x
• Subtask: Merge Thuenen-GeoNode-Development/MapStore2 with upstream 2024.02.xx
• Subtask: Merge Thuenen-GeoNode-Development/geonode-mapstore-client with upstream 4.4.x
• Subtask: Support for GeoNode v4.4.x GeoNodeUserGroup-DE/contrib_datapackage#23
• After upgrade, see if a backported version of No linebreak in DetailsPanel GeoNode/geonode-mapstore-client#1854 will be available. (actually already part of the thuenen fork)

[gannebamm]

@ridoo Upgrading to 4.4.x will most likely also resolve this issue: geosolutions-it/geonode-subsites#45 (comment)
right?

[ridoo]

Last geonode-subsite release is from Spring 2024, therefore thuenen_atlas includes main as it includes my fix to align with v4.3.x. Once it is merged to main, it will be part of thuenen_atlas. If geosolutions intends to tag or even release current main branch, I will take care of pointing to that version.

[gannebamm]

We are currently testing subsite exclusive features with the branch https://github.com/geosolutions-it/geonode-subsites/tree/subsite_exclusive which is included in our test instance as seperated branch (https://github.com/Thuenen-GeoNode-Development/thuenen_atlas/compare/subsite_exclusive_test) and integrated like 4183280

[ridoo]

@gannebamm I will install from branch subsite_exclusive which is not merged yet. This will give you the chance to test the whole v4.4.x update on thuenen_4.x (I am mostly through 😅 ).

[ridoo]

@gannebamm please review and test: https://github.com/Thuenen-GeoNode-Development/thuenen_atlas/blob/thuenen_4.x

In particular, I aligned thuenen_atlas with the geonode blueprint so that we do not have a non-related history anymore.

A quick exclusive subsite test seemed to work as expected. But please test on your own.

[ridoo]

Intiated UPDATE.md (currently more a scratchpad)

[ridoo]

detailed update documentation is out of scope. But it should include:

• why blueprint etc?
• give high level overview of interdependent repositories
• big picture needed with brief description

Edit: @hvwaldow I updated the update description. Feel free to review it and give feedback

[vineetasharma105]

Issue in the preview of the layers harvested from remote service.
-As a sample, this dataset from external service on the preview shows the Holisoils banner as can be seen here :

This preview issue exists only for layers from remote services.
-For 'external applications' , the preview show 'Bookmark' issue :

-The previews in case of other layers are working fine.

[vineetasharma105]

Also, the preview on geonode-demo is working fine as can be seen here :

But the same layer when made subsite exclusive, shows the erroneous preview :

[ridoo]

@vineetasharma105

• The given example dataset is not public so I cannot have a look unfortunately The other examples you gave are accessible from the subsite -- I will give them a quick test. My current guess is, that you observe a side effect from the slug changes Mattia did to support exclusive datasets for subsites. Perhaps remote services are not supported yet (all other public dataset seem to work fine).
• For externalapplications the subsites URL slug configuration would have to be extended to included the externalapplications

[vineetasharma105]

Hi Henning,
Yes , I also not exclusively had a look at the access options for anonymous users as the default 'allowed permissions' are view and download. Still I now made those layers 'Viewable' for anyone via the frontend.
Please let me know if in case any other parts have to be taken care.

[ridoo]

There are recent changes made by Mattia regarding remote services. However, locally I make the same observation you did. Perhaps, I have to adjust integrate his _geonode_config.html configuration (which actually should be automatically respected .. I will check)

[ridoo]

@vineetasharma105 I fixed the externalapplication issue. It now shows the thumbnail instead of trying to render an embedded view:

Also the remote service instance should be ok now as well:

[ridoo]

@gannebamm @vineetasharma105 @hvwaldow I updated the thuenen_atlas which includes the latest fixes.

[gannebamm]

Is deployed

[vineetasharma105]

Henning, it could also be that because geonode-demo is not upgraded yet , I am not able to add/create external application in subsite. For eg. I am here not getting the option in the 'Add resource' list

Although, if i manage to filter resources with 'external resources', then I not only get the filtered external resources, but now also getting the option to add a resource as external application :

But again, the newly created external application resource will be part of geonode-demo but not the holisoils subsite and the process of adding the group 'holisoils' and subsite_exclusive keyword will shift this resource to subsite contents. The preview is still problematic. Let me check it on the geonode-demo with the latest fixes you mentioned.

[ridoo]

@vineetasharma105 that externalapplications are accessible only from catalogue is a known issue. For now, it is a known limitation. I will have to check, if we have resources left to dig deeper here.

But again, the newly created external application resource will be part of geonode-demo but not the holisoils subsite and the process of adding the group 'holisoils' and subsite_exclusive keyword will shift this resource to subsite contents.

That is similar to remote services, as the integration of adding externalapplications are still based on Django forms.

Please check the preview issue. It worked for me locally.

[gannebamm]

@ridoo Sorry, I messed up (again) with the rebuild and old versions of the submodules were used. Vineeta is doing a recheck at the time of this writing.

[vineetasharma105]

Hi @ridoo :
Florian just told me about how to make the external application public and I apologize I did not know this before. All I wanted to do was to make it public so that you can also view it and I can present the resource where the preview issue was there on the geonode-demo/holisoils.
But I have checked it now and the preview is working fine :

👍

[ridoo]

@vineetasharma105 @gannebamm I took some time now to investigate what is wrong with the non-paged route / and why externalapplications menu items are not visible (but visible on other, paged routes).

It seems to be an issue on upstream geonode-mapstore-client where overridden config does not get applied for / for some reason. I created an upstream issue and documented it on the externalapplication contrib module repository (known issue).

The only workaround I see is to add the externalapplication menu entry as code in our geonode-mapstore-client fork. I am about to apply the workaround on Thuenen-GeoNode-Development/geonode-mapstore-client and will provide an updated thuenen_atlas once everything is in place.

Edit: External Application is now available from the "Add ResourceMenu even on/ `.

@gannebamm you can re-deploy the latest changes
@vineetasharma105 feel free to test .. however, the subsite_exclusive and group settings still have to be done via Django Admin (as for remote services)

Edit: More todo 😅 : https://github.com/Thuenen-GeoNode-Development/Sprints/issues/10#issuecomment-2517163495

[ridoo]

I addressed the TODO mentioned in https://github.com/Thuenen-GeoNode-Development/Sprints/issues/10#issuecomment-2517163495. When successfully tested, this should mark the final task for this issue.

[vineetasharma105]

Hi Henning,
The 'external applications' option is now available when adding a resource on the first page. And also working.

[ridoo]

@gannebamm @vineetasharma105 can this be closed then?