Use std::invalid_argument -> ValueError for config errors

TileDB-Inc · Jul 17, 2020 · 689c60b · 689c60b
1 parent 55bee6a
commit 689c60b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/tiledb/core.cc b/tiledb/core.cc
@@ -269,7 +269,7 @@ class PyQuery {
           std::stoull(tmp_str);
       } catch (const std::invalid_argument &e) {
         (void)e;
-        throw TileDBError("Failed to convert 'py.init_buffer_bytes' to uint64_t ('" + tmp_str + "')");
+        throw std::invalid_argument("Failed to convert 'py.init_buffer_bytes' to uint64_t ('" + tmp_str + "')");
       }
     }
 
@@ -280,7 +280,7 @@ class PyQuery {
           std::stoull(tmp_str);
       } catch (const std::invalid_argument &e) {
         (void)e;
-        throw TileDBError("Failed to convert 'py.exp_alloc_max_bytes' to uint64_t ('" + tmp_str + "')");
+        throw std::invalid_argument("Failed to convert 'py.exp_alloc_max_bytes' to uint64_t ('" + tmp_str + "')");
       }
     }
 
@@ -291,7 +291,7 @@ class PyQuery {
       } else if (tmp_str == "false") {
         deduplicate_ = false;
       } else {
-        throw TileDBError("Failed to convert configuration 'py.deduplicate' to bool ('" + tmp_str + "')");
+        throw std::invalid_argument("Failed to convert configuration 'py.deduplicate' to bool ('" + tmp_str + "')");
       }
     }
 

diff --git a/tiledb/tests/test_core.py b/tiledb/tests/test_core.py
@@ -16,6 +16,10 @@ def test_pyquery_basic(self):
             pass
 
         with tiledb.open(uri) as a:
+            with self.assertRaises(ValueError):
+                testctx = tiledb.Ctx(config={'py.init_buffer_bytes': 'abcd'})
+                core.PyQuery(testctx, a, ("",), False, 0)
+
             q = core.PyQuery(ctx, a, ("",), False, 0)
 
             try: