-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When there are errors in the file code , why am I still getting +1 as code review in gerrit #142
Comments
Hi, can you please attach Sputnik execution logs? |
@pjagielski Here in this file I've attached Execution Logs: |
So in this log Sputnik complains about no jshint.json configuration, but there nothing regarding JSLint. Do you have |
@pjagielski No, jslint.enabled=false and Do I have to manually create jshint.json configuration, sputnik is supposed to take care of the configuration of PMD, Jshint etc because they are inbuilt right? Or Do we have to manually configure them [PMD, Jshint, Checkstyle, Codenarc etc]? The contents of my sputnik directory are "bin, gerrit.properties, lib" I'm assuming when you are saying "sputnik.properties" file as "gerrit.properties" file which I am using under sputnik directory here Iam attaching it. |
@karthikvee did you manage to solve this configuration problem? |
I am testing the following code in a file test.js with jshint like $jshint test.js:-
function myFunction(p1, p2) { ; ; return p1 == p2; // The function returns the product of p1 and p2 }
and Iam getting following error
But while testing it using sputnik on gerrit, sputnik is giving +1 for it. When there are errors in the file , why am I still getting +1 as code review in gerrit
The text was updated successfully, but these errors were encountered: