Should total_height ignore offset due to header rows?

[bzm3r]

Suppose I want to get the total height of a sheet, including header rows. Currently, the only way to do this is to load_sheet with header_row=None and then to get the total_height, because total_height currently is sensitive to the number of header rows:

fastexcel/src/types/python/table.rs

Line 234 in aa0ab77

let total_height = self.data().height() - self.header.offset();

Should total_height also include the number of header rows (i.e. be insensitive to the number of header rows)?

[lukapeschke]

I agreee that the name is confusing, but we cannot break existing behaviour. What we could do is deprecating the current height, width, total_width and offest properties on the ExcelSheet and ExcelTable types, and introduce a new property which would contain all the shape-related information, including:

• offset
• limit
• data_height , the height of the selected data
• width
• total_height_raw , the height of the entire sheet (what you want)
• total_data_height, the height of the entire data, i.e. total height - header offset (the current total_height proprety).

Naming is not one of my strengths, so I'm open for suggestions on this :)

@PrettyWood what are your thoughts on this ?