Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed_siege_assembly_cooldown Setting Not Working #939

Open
pelicano0 opened this issue Oct 29, 2024 · 5 comments
Open

failed_siege_assembly_cooldown Setting Not Working #939

pelicano0 opened this issue Oct 29, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@pelicano0
Copy link

Describe the bug
When I set the failed_siege_assembly_cooldown to 12 hours, I can attempt to declare war on the same town again before the 12 hours have passed if the war is canceled.

Expected behavior
Not being able to declare war again before 12 hours have passed.

Versions (please complete the following information):

  • Towny: 0.100.4.0
  • SiegeWar: 2.14.1
  • Purpur: 1.21.1
@pelicano0 pelicano0 added the bug Something isn't working label Oct 29, 2024
@LlmDl
Copy link
Member

LlmDl commented Oct 29, 2024

It would be good to have your siegewar config.

@pelicano0
Copy link
Author

I can reproduce this error even with the default configuration.

@LlmDl
Copy link
Member

LlmDl commented Nov 4, 2024

Ok, what did you mean by "if the war is canceled."

I need clearer instructions on how to reproduce your results.

@pelicano0
Copy link
Author

In the SiegeWar configuration, if the assemblies_enabled setting is enabled and the failed_siege_assembly_cooldown is set to, for example, 12 hours, you can start a siege assembly by placing a banner in any town, and if it fails, you are still able to start another siege assembly by placing another banner in the same town. However, the intended behavior is that you should not be able to start another siege in the same town within 12 hours (or the specified cooldown time) until that period has passed.

@LlmDl
Copy link
Member

LlmDl commented Nov 5, 2024

In what manner is your siege assembly failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants