Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Stimulus automatic event handling #526

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Improvements to Stimulus automatic event handling #526

merged 4 commits into from
Dec 4, 2024

Conversation

spohlenz
Copy link
Member

This PR improves on the changes in #524 by:

  • Preventing actions from being bound multiple times (which could previously happen if elements were removed and re-added to the DOM)
  • Added a corresponding removeAction method
  • Extracted an actionsList getter

@spohlenz spohlenz force-pushed the stimulus-actions-fixes branch from 27b1bdf to 4ce8062 Compare December 4, 2024 03:10
@spohlenz spohlenz merged commit 0e112ec into main Dec 4, 2024
43 checks passed
@spohlenz spohlenz deleted the stimulus-actions-fixes branch December 4, 2024 05:01
@coveralls
Copy link

Coverage Status

coverage: 91.421%. remained the same
when pulling d5b7d3b on stimulus-actions-fixes
into 350f6d6 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spohlenz @coveralls