Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RMDx8] Use Inheritance and OOP to Create a RMDx8 Data Classes #78

Open
loukylor opened this issue Oct 26, 2024 · 0 comments
Open

[RMDx8] Use Inheritance and OOP to Create a RMDx8 Data Classes #78

loukylor opened this issue Oct 26, 2024 · 0 comments

Comments

@loukylor
Copy link
Member

Context

Currently, data classes for the Moteus Controllers are hardcoded. This needs to change as we implement the RMDx8s and potentially add more motor classes.

Task

Separate the Moteus classes. Specifically, lib.configs.MoteusMotorConfig, lib.moteus_motor_state.MoteusMotorState, and lib.moteus_motor_state.MoteusRunSettings need to be split into corresponding base classes and RMDx8 specific classes. This involves figuring out what interfaces are in common with Moteus, places those in the base classes, then placing everything into the RMDx8 classes.

Be sure to follow how the current classes are setup in terms of inheritance, and if you have any question, feel free to reach out.

Resources

https://github.com/2b-t/myactuator_rmd

Relations

#66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant