Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper names #128

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Proper names #128

wants to merge 5 commits into from

Conversation

LunaUrsa
Copy link
Contributor

@LunaUrsa LunaUrsa commented Apr 7, 2024

We should strive to use the proper chemical name of each substance instead of any kind of slang name. This PR shows what the DB would look like if we replaced all slang names with their proper chemical name.

EG: LSD becomes lysergic acid diethylamide in drugs.json and combos.json
IE: This will not affect descriptions that mention "lsd", only the key, name, pretty name, and combo info

I generally like this change, but as I've been doing these formatting scripts I've been mulling around the idea that we keep combos.json in the slang names, and then we would have a formatting script run and take the slang names from combos.json and populate drugs.json with the chemical names? Idk, just a thought

So this PR is here for people to review but i don't suggest we actually merge this right now

@LunaUrsa LunaUrsa requested a review from utaninja April 7, 2024 13:59
@LunaUrsa LunaUrsa self-assigned this Apr 7, 2024
@LunaUrsa
Copy link
Contributor Author

LunaUrsa commented Apr 7, 2024

The output of changes with the above logic is followed.
Note that ~ means "modified", so "the script modified alcohol to be ethanol"

~ alcohol   = ethanol
~ amt       = alpha-methyltryptamine
~ dmt       = dimethyltryptamine
~ ghb/gbl   = gamma hydroxybutyrate
~ ghb/gbl   = gamma-butyrolactone
~ lsd       = lysergic acid diethylamide
~ mdma      = 3,4-methylenedioxymethamphetamine
~ mushrooms = psilocybin mushrooms
~ mxe       = methoxetamine
~ pcp       = phencyclidine

@utaninja utaninja added the meta Meta discussions & more label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Meta discussions & more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants