Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build and test book job not failing workflow when book fails tests #270

Open
Trouv opened this issue Nov 26, 2023 · 0 comments
Open

build and test book job not failing workflow when book fails tests #270

Trouv opened this issue Nov 26, 2023 · 0 comments

Comments

@Trouv
Copy link
Owner

Trouv commented Nov 26, 2023

The intention of this CI job is to make sure the book never breaks when changes are made to it or the codebase. This only works if the book failing to test/build actually fails the CI. Currently, mdbook-keeper is catching failed tests, but it seems to not be exiting with code 1 and passing the job regardless.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Trouv