check the dkg size against the threshold if we timeout waiting for Dk…

…gPublicShares
Trust-Machines · Dec 20, 2023 · 352f13b · 352f13b
1 parent bd99ddd
commit 352f13b
Showing 1 changed file with 18 additions and 6 deletions.
diff --git a/src/state_machine/coordinator/fire.rs b/src/state_machine/coordinator/fire.rs
@@ -69,12 +69,24 @@ impl<Aggregator: AggregatorTrait> Coordinator<Aggregator> {
                 if let Some(start) = self.dkg_public_start {
                     if let Some(timeout) = self.config.dkg_public_timeout {
                         if now.duration_since(start) > timeout {
-                            error!("Timeout gathering DkgPublicShares for dkg round {} signing round {} iteration {}, unable to continue", self.current_dkg_id, self.current_sign_id, self.current_sign_iter_id);
-                            let wait = self.dkg_wait_signer_ids.iter().copied().collect();
-                            return Ok((
-                                None,
-                                Some(OperationResult::DkgError(DkgError::DkgPublicTimeout(wait))),
-                            ));
+                            // check dkg_threshold to determine if we can continue
+                            let dkg_size = self
+                                .dkg_public_shares
+                                .iter()
+                                .map(|(_id, shares)| shares.comms.len() as u32)
+                                .sum();
+                            if self.config.dkg_threshold > dkg_size {
+                                error!("Timeout gathering DkgPublicShares for dkg round {} signing round {} iteration {}, dkg_threshold not met ({}/{}), unable to continue", self.current_dkg_id, self.current_sign_id, self.current_sign_iter_id, dkg_size, self.config.dkg_threshold);
+                                let wait = self.dkg_wait_signer_ids.iter().copied().collect();
+                                return Ok((
+                                    None,
+                                    Some(OperationResult::DkgError(DkgError::DkgPublicTimeout(
+                                        wait,
+                                    ))),
+                                ));
+                            } else {
+                                // we hit the timeout but met the threshold, continue
+                            }
                         }
                     }
                 }