Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull in bitcoind test from stacks-sbtc #24

Open
xoloki opened this issue Oct 3, 2023 · 1 comment
Open

Pull in bitcoind test from stacks-sbtc #24

xoloki opened this issue Oct 3, 2023 · 1 comment
Assignees
@soju-drinker

Comments

@xoloki
Copy link
Collaborator

xoloki commented Oct 3, 2023 •
edited by jio-gl
Loading

The old stacks-sbtc repo is currently somewhat of a problem. It represents the old sBTC Alpha design, which has been superseded by the new Alpha Romeo developer release, and only bears passing resemblance to the final Nakamoto sBTC.
So we would like to get rid of stacks-sbtc, but there are external collaborators who use it to learn how to use wsts to sign taproot bitcoin transactions.

To solve this dilemma, take the frost_btc code from stacks-sbtc/frost-test/tests/frost-btc and reimplement it using the state machines as per the test_process_inbound_messages test in wsts::state_machine::test. It will be necessary to pull in a minimal amount of code from stacks-sbtc/test-utils/src/lib.rs, specifically the BitcoinProcess and generate_wallet code, while trying to avoid the SignerHelper code.

Doing this task will not only allow the removal of stacks-sbtc, but also be an excellent primer on the current state machine design of stacks-signer.
jcnelson pushed a commit to jcnelson/wsts that referenced this issue Oct 5, 2023
@sergey-shandar @xoloki
fill out readme; use readme as crate level documentation; add comment… (
b1ce248 
Trust-Machines#24)

* fill out readme; use readme as crate level documentation; add comments for all modules; start filling in docs for point functions

* fill in rest of doc comments

* make shell snippets single line

---------

Co-authored-by: Joey Yandle <[email protected]>
@AshtonStephens
Copy link

@soju-drinker we're trying to remove this repository, when do you think this will be done?

@djordon djordon mentioned this issue Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soju-drinker soju-drinker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xoloki @AshtonStephens @soju-drinker