Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State machines do not handle errors well #52

Open
xoloki opened this issue Feb 12, 2024 · 1 comment
Open

State machines do not handle errors well #52

xoloki opened this issue Feb 12, 2024 · 1 comment
Assignees

Comments

@xoloki
Copy link
Collaborator

xoloki commented Feb 12, 2024

While testing an initial implementation of #51 it became apparent that errors in the coordinator state machine process loop fell through to the top level, which meant that we did not return an error packet, we just logged an error locally.

Update the state machines to always check for errors when it is possible to return an error packet, and do so if necessary.

@xoloki xoloki self-assigned this Feb 12, 2024
@xoloki
Copy link
Collaborator Author

xoloki commented Nov 1, 2024

Commit 2d57f20 returns an OperationResult::SignError when gather_sig_shares fails. We were already doing this for DkgError. There are lots more ? error redirects in the coordinator process_message loops, they should all be examined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant