Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up logging with named parameters #99

Open
xoloki opened this issue Nov 25, 2024 · 1 comment
Open

Clean up logging with named parameters #99

xoloki opened this issue Nov 25, 2024 · 1 comment
Assignees
@xoloki @tonyjzhou
Labels
good first issue Good for newcomers

Comments

@xoloki
Copy link
Collaborator

xoloki commented Nov 25, 2024

The tracing crate has support for logging named parameters, which wsts does not currently use. This makes the logs more explicit, and tracks how other crates use them.

So instead of

info!("Signer {} received DkgPublicShares", signer_id);

We could instead do

info!(%signer_d, "received DkgPublicShares");
@xoloki xoloki self-assigned this Nov 25, 2024
@xoloki xoloki added the good first issue Good for newcomers label Nov 25, 2024
@xoloki xoloki assigned xoloki and unassigned xoloki Nov 25, 2024
@xoloki xoloki mentioned this issue Nov 25, 2024
Merged
@tonyjzhou tonyjzhou mentioned this issue Dec 2, 2024
Open
@tonyjzhou
Copy link
Contributor

tonyjzhou commented Dec 2, 2024 •
edited
Loading

@xoloki PR for review: #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xoloki xoloki

@tonyjzhou tonyjzhou

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xoloki @tonyjzhou