Process coordinator messages to duplicate state between multiple coordinators #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoloki
requested changes
Dec 18, 2023
jferrant
force-pushed
the
feat/consistent-state-across-signers
branch
3 times, most recently
from
e32a18d to
98ced98
Compare
xoloki
approved these changes
Dec 19, 2023
…hine Signed-off-by: Jacinta Ferrant <[email protected]>
jferrant
force-pushed
the
feat/consistent-state-across-signers
branch
from
98ced98 to
73087f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables signers and coordinators to all duplicate state by attempting to process received coordinator messages as they arrive (only processing them if they are in the expected state. otherwise the message is ignored.)
I also added verify_msg and tests for it to the network crate as it seems like it should live here and not in stacks signer itself.
TODO: if this is approved. I will go about the process of updating FIRE. But am wary to do so until this is given the green light. Also until we have a FIRE test in stacks-core to verfy I don't eff things up.