-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep polynomial constant parameters during DKG #92
Open
xoloki
wants to merge
21
commits into
main
Choose a base branch
from
keep-constant
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoloki
changed the title
Keep polynomial constant during DKG
Keep polynomial constant parameters during DKG
Oct 8, 2024
…x compute::private_poly by exponentiating the arg
1 task
…o Polynomial to make code cleaner
…alue from the arg
djordon
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Largely, looks good. I gave it a quick look though but will give another one later. Figured I'd add my questions and comments here until then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group key created during dkg is the sum of the constant parameters of the party polynomials. This change adds the ability to keep these constant parameters when rerunning dkg, so the group key stays the same. Tests show that it works on both the low level
Signer
interface and the high level state machines.This change also adds
common::Polynomial
, in an attempt to fix the disparity between how we handle private and public polynomials. Private polynomials, which useScalar
for both parameters and args, have been usingpolynomial::Polynomial
from an external crate. But we weren't using any of the advanced features from that crate, just callingeval
to generate private shares. Public polynomials couldn't use the crate, because they havePoint
parameters butScalar
args, which the crate did not support. Also, we couldn't support thekeep_constant
feature with the crate, since it did not allow specifying or editing any of the polynomial parameters.This change is now using
common::Polynomial
for private polynomials, butVec<Point>
for public polynomials (with some help from Polynomial to convert between the two). This is similar to how the code worked before this change, so should require few downstream changes.