Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Exchange name displayed over two lines isn't crossed when user clicks on it #338

Open
2 of 4 tasks
adeacetis opened this issue Jun 12, 2023 · 1 comment
Open
2 of 4 tasks
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@adeacetis
Copy link
Collaborator

adeacetis commented Jun 12, 2023

Describe the issue

As a user, I can disable an exchange by clicking on the exchange name in the global settings pane > section exchanges.

If the name appears on two lines, the animated strike-through is located in the middle instead of over the name.

Top is the issue.
Bottom is how I would expect it.

image

Steps to reproduce

This occurs on mobile OR when the settings panel is sized down at the open.

  1. Click on the bottom right green circle button to open the global setting pane.
  2. Scroll to the exchange settings.
  3. Click on Binance Futures US

Expectations

I would expect the line to be over the name and not in the middle

Solutions

1a. Truncate the name if it's too long (it's the easiest way to do so) and would be valid on mobile, tablet, and desktop

1b. Display the exchange on one column instead of two when the pane is too narrow.

On the desktop, we could also force the pane to open at a certain width so the issue wouldn't appear.

On a tablet, it's not a problem as the pane takes the whole screen in width and height and it's enough for the names to be displayed entirely even in portrait mode.

To-do

  • I added my browser's console output in the issue (open the console first, try to reproduce the issue then see if there is anything)
    NA
  • I have attached an export of my aggr database in the issue
    NA
  • I documented the issue with screenshots
  • I provided a clear and concise description of what the bug is (see both sections below)
@adeacetis adeacetis added bug Something isn't working good first issue Good for newcomers labels Jun 12, 2023
@adeacetis
Copy link
Collaborator Author

Given the recent trouble Binance and Binance Futures are going through. This issue is clearly not a top priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant