Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Error thrown when no more data to fetch #372

Open
3 of 4 tasks
adeacetis opened this issue Oct 12, 2023 · 0 comments
Open
3 of 4 tasks

[BUG] Error thrown when no more data to fetch #372

adeacetis opened this issue Oct 12, 2023 · 0 comments
Assignees

Comments

@adeacetis
Copy link
Collaborator

  • I checked my browser's console output for errors and included it in the issue if any

image

  • I have attached an export of my aggr database in the issue
    NA
  • I documented the issue with screenshots
  • I provided a clear and concise description of what the bug is (see both sections below)

HistoricalService is currently throwing an error when it reaches the end of the fetched data's range.

The desired behavior is for the HistoricalService to notify the user when it has fetched all available data and is stopping, instead of throwing an error.

if (!json.results.length) {
  throw new Error('No more data')
}

Of course, if the service fails it should throw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants