Check Scratch.canDownload before downloading files #1798
Merged
+42
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not clear whether the download blocks should wait until the prompt is complete before resuming the script or keep executing and let the user handle the popup in the background |
You should probably just wait for the prompt and then let the user handle the rest. Dealing with the browser prompt(s) etc. |
yuri-kiss
added
the
pr: change existing extension
|
Wait for the prompt. Better security choice |
|
Whether the blocks wait or not has no security impact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TurboWarp/scratch-gui#969