-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* replaced a closure with `Fix1` * added correct implementation of `getrange` for `TypedVarInfo` * fixed calls to varinfo methods which should be metadata methods * fixed typo * use `setval!` on the metadata directly instead of on the varinfo * added `length` implementation for `VarInfo` and `Metadata` * added testing for `getranges * introduce `vector_length` instead of `length`, since `length` already refers to the dictionary-like length impl, not vector-like * fixed bug in `getranges` for untyped varinfo * added proper testing for other `VarInfo` types * bump patch version * separated the `getrange` version which returns the range of the vecto representaiton rather than the internal representaiton into `vector_getrange` to make its function explicit * formatting * removed `vector_getrange` for metadata * added handling of missing indices + tests for these cases * added handling of duplicated values * removed no-longer relevant comment * fixed impl of `vector_getrange` and `vector_getranges` for threadsafe varinfo * fixed `vector_getranges` when `vns` are not found
- Loading branch information
Showing
5 changed files
with
130 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a58571
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JuliaRegistrator register
5a58571
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Registration pull request created: JuliaRegistries/General/120823
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via: