Defer user logout on HIT submission #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizzao
force-pushed
the
hit-submission-fix
branch
from
2b53808 to
f312dda
Compare
|
One reason this approach might cause issues is that it will log a user out right after accepting a new HIT, because of the delay. This would not work for apps that allow users to do a sequence of HITs. |
mizzao
force-pushed
the
master
branch
2 times, most recently
from
02a0a3e to
b9ea3c0
Compare
mizzao
force-pushed
the
master
branch
2 times, most recently
from
457c6fe to
c3d5913
Compare
|
TODO: rebase this on the JS version of the file. |
mizzao
force-pushed
the
hit-submission-fix
branch
from
7508a87 to
3d8b88d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes (maybe) one of the potential issues described in #28, where there is a race condition on the client between the browser logging itself out and the HIT submitting to MTurk. In the case where the former happens first, the MTurk submit form doesn't work properly and the user sees an error.
This is not a reliable bug to reproduce, but we've seen it enough that if this works in most cases it may be better than what we have so far.