Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Security ] #2777

Open
AndrewMohawk opened this issue Nov 22, 2024 · 1 comment
Open

[ Security ] #2777

AndrewMohawk opened this issue Nov 22, 2024 · 1 comment
Labels
enhancement Improved functionality

Comments

@AndrewMohawk
Copy link

Please see: shikijs/shiki#843

TL;DR -- the latest update to Shikijs includes some new dependencies that are not used much and also have the same single maintainer. This may introduce dependency risk as this is such a high used library

@AndrewMohawk AndrewMohawk added the enhancement Improved functionality label Nov 22, 2024
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Nov 22, 2024

I don't think there's anything I'm going to do about this -- I trust antfu by proxy as he's a friend of a friend, and if he is adding additional libraries which may eventually lead to being able to drop the current massive wasm blob that is oniguruma... well, that seems like an overall win for security!

It's probably worth mentioning that TypeDoc was one of the first adopters of Shiki, ~4 years ago when the project started (yes, it's older than that on npm, but the Shiki project that we know today is only 4 years old), adding it as a dependency of TypeDoc. I believe it had <10k downloads/week at that point.

If you're concerned about single-user maintained projects, well, I'm pretty sure both Shiki and TypeDoc qualify. antfu has done almost all of the work for Shiki, and I have effectively been the sole maintainer of TypeDoc for the past 5 years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improved functionality
Projects
None yet
Development

No branches or pull requests

2 participants