Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overall Latin / Cyrillic / Greek / SSA review #18

Open
emmamarichal opened this issue Sep 19, 2024 · 12 comments
Open

Overall Latin / Cyrillic / Greek / SSA review #18

emmamarichal opened this issue Sep 19, 2024 · 12 comments

Comments

@emmamarichal
Copy link

emmamarichal commented Sep 19, 2024

Hi @josescaglione,
cc @vv-monsalve @chrissimpkins @davelab6

Viv generated a lot of proofs to check, for each languages. I put here a first review (mainly outlines and anchors).
Review done on Google Chrome / Mac

Playpen_review_180924.pdf

I'll complete that issue with my review on Windows.
cheers!

@vv-monsalve
Copy link
Collaborator

@josescaglione This PDF corresponds with the one I sent you yesterday and the round 1 proofs produced at commit 13ffdf3 Update fea RightToLeft lookup flag.

As we discussed during yesterday's meeting, some reported issues might have already been solved since you continued working on the fonts.

@josescaglione
Copy link
Collaborator

Thanks, we will review, no problem

@vv-monsalve vv-monsalve changed the title Playpen review - Cyrillic / Greek / SSA Latin / Cyrillic / Greek / SSA review Sep 19, 2024
@vv-monsalve
Copy link
Collaborator

I'll continue adding here the feedback for the LGC and SSA as I receive it.

@josescaglione
Copy link
Collaborator

I have a few comments in the PDF, We are missing several text strings we need to sort this out.

Playpen_review_180924.pdf

@vv-monsalve
Copy link
Collaborator

vv-monsalve commented Sep 19, 2024

Some answers to the PDF notes:

  • Cyrillic strings: I'll provide the strings here after I recreate the proofs using the font currently in the repo (commit e6f01d6) Done by email.

  • Greek:

    the text sample is wrong, caps only have tonos at the begining of a word"

    I've clarified that and deleted that section from the sample.

  • SSA strings : Most SSA samples are taken from Octopus

  • chook.alt3 indeed gives a misplaced impression :)

@josescaglione
Copy link
Collaborator

chook.alt3 is a 2-stroke construction of the glyph. It was drawn like this purposedly. If you want it changed we are still on time, just let us know.

@josescaglione
Copy link
Collaborator

@vv-monsalve As far as I understand all of the fixable issues are fixed in the latest version, we even added basic lc to UC kerning. We can go over anything that you consider still open together in a call to make things easier

@vv-monsalve
Copy link
Collaborator

@josescaglione Great. However, I'll keep bringing to the issue tracker the feedback provided by all the reviewers before creating round 2 of proofs.

@vv-monsalve vv-monsalve changed the title Latin / Cyrillic / Greek / SSA review Overall Latin / Cyrillic / Greek / SSA review Sep 23, 2024
@vv-monsalve
Copy link
Collaborator

Hi, @josescaglione, I'm bringing here the feedback provided by @kosbarts on LGC.

PPS-Review-Kostas 092324.pdf

This PDF corresponds with the one he sent you by email. Kostas reported he used a more updated font you provided him, so I can't track the commit to which that font belongs.

Some reported issues might have already been solved since you continued working on the fonts.

@josescaglione
Copy link
Collaborator

Hi @vv-monsalve the issues raised by Kostas in Greek and LATX were sorted out. We will review the arabic and cyr ones

@josescaglione
Copy link
Collaborator

Update, the issue spotted by Kostas about Arabic shaping for Kurdish has been fixed

Screenshot 2024-09-24 at 15 31 51

@vv-monsalve
Copy link
Collaborator

Hi @josescaglione, I'm bringing here the feedback provided by @MariannaPaszkowska for the at commits:

  • LG SSA - 13ffdf3 Update fea RightToLeft lookupflag
  • CYR - e6f01d6 fix a anchor

PPS-LGC-SSA-Marianna.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants