Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update mechanism #119

Open
zuphilip opened this issue Jan 2, 2020 · 3 comments
Open

Add update mechanism #119

zuphilip opened this issue Jan 2, 2020 · 3 comments
Labels
enhancement Any enhancement on the software itself (excluding new transformations)

Comments

@zuphilip
Copy link
Member

zuphilip commented Jan 2, 2020

Commit OCR-D/format-converters@5b9568f was missing in our installation (fixed now). I noticed that just running make all or make install does not update any of the existing cloned code from external git repositories. I think we should start using git submodules to get explicit dependencies.

Originally posted by @stweil in #106 (comment)

@zuphilip
Copy link
Member Author

zuphilip commented Jan 2, 2020

I am not sure that we need git submodules with which a lot of people also struggle to use. Moreover, this would only bee a partial update mechanism because we also directly install from a release (e.g. JPageConverter) or download from a website (e.g. Saxon).

Thus, I think we need a proper update mechanism in the Makefile. This then should check first for new code of ocr-fileformat and taking into account that there are git-installations as well as installations for the latest release. Afterwards possible updated packages from the vendor should be loaded. This maybe can been done with make realclean and then make install again. Maybe there are smarter ways to do it as well w/o downloading potentially the same files again.

@zuphilip zuphilip added the enhancement Any enhancement on the software itself (excluding new transformations) label Jan 2, 2020
@kba
Copy link
Collaborator

kba commented Jan 2, 2020

Thus, I think we need a proper update mechanism in the Makefile.

Easiest solution: clone the repository depth-1 to a tempdirectory, uninstall, reinstall. It's less efficient, but the cleanest.

@bertsky
Copy link
Contributor

bertsky commented Jun 6, 2023

I am not sure that we need git submodules with which a lot of people also struggle to use. Moreover, this would only bee a partial update mechanism because we also directly install from a release (e.g. JPageConverter) or download from a website (e.g. Saxon).

Yes, but both can be managed via make. And that's exactly what since has been done.

Thus, I think we need a proper update mechanism in the Makefile. This then should check first for new code of ocr-fileformat and taking into account that there are git-installations as well as installations for the latest release. Afterwards possible updated packages from the vendor should be loaded. This maybe can been done with make realclean and then make install again. Maybe there are smarter ways to do it as well w/o downloading potentially the same files again.

The process for updating is now as simple as:

git pull
make install # will also git submodule update

Can be closed IIUC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any enhancement on the software itself (excluding new transformations)
Projects
None yet
Development

No branches or pull requests

3 participants