Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for fJVT implementation #1570

Open
jdandoy opened this issue Sep 29, 2022 · 1 comment
Open

Fixes for fJVT implementation #1570

jdandoy opened this issue Sep 29, 2022 · 1 comment
Assignees

Comments

@jdandoy
Copy link
Contributor

jdandoy commented Sep 29, 2022

  • fJVT current uses CentralMaxPt, but should use ForwardMaxPt.
  • It's not clear that JetForwardJvtTool is correct for PFlow jets, as there's also a JetForwardPFlowJvtTool. Currently following up with the ETmiss + pileup tagging subgroup. JetForwardJvtTool is the correct tool, JetForwardPFlowJvtTool performs a different task at the derivation stage.
  • May want the option to use the derivation-level decoration, though note this may not have the correct pt threshold set, requiring an additional check before using.
  • The fJVT tool currently doesn't use the correct maximum pt threshold, so we should set it correctly as a default option here. The R21.2 instance does set it correctly to 60 GeV.
  • Could remove the hardcoding of the JVT likelihood file in anticipation of future updates.
@jdandoy jdandoy self-assigned this Sep 29, 2022
@miholzbo
Copy link
Contributor

FYI: In R22 we will (hopefully) handle this much more streamlined and use the JetJvtEfficiency as interface for all JVT-related taggers. My MR for athena is developing here and the associated branch to adjust the handling in xAH is in my xAH fork here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants