Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: info switch python parsing #1317

Closed
wants to merge 17 commits into from

Conversation

kratsg
Copy link
Contributor

@kratsg kratsg commented Feb 8, 2019

This provides a JSON file that will be checked for changes in Travis-CI builds for helping with info switch parsing. A later PR will parse this to check against a provided xAH configuration for specific info-switches.

This PR also moves a lot of the declarations back into the header file for info switches.

/cc @mattleblanc

@kkrizka
Copy link
Contributor

kkrizka commented Feb 8, 2019

Can you try to keep the initializations in the cpp file? This will cause everything to recompile anytime we try to tweak the code.

@kratsg
Copy link
Contributor Author

kratsg commented Feb 8, 2019

Can you try to keep the initializations in the cpp file? This will cause everything to recompile anytime we try to tweak the code.

Clang won't parse it. If you can figure out a way to get around the fact that clang only parses one file at a time...

@kkrizka
Copy link
Contributor

kkrizka commented Feb 8, 2019

By not using clang for this check. I would run the check at run time as I suggested in #1315 (user should run a test job before submitting to grid anyways...) or somehow force the info switches to initialize at submission time.

Putting code in the header also increases compile time. Any class that includes the HelperFunctoins (aka any class) will have to recompile all this code.

@kratsg
Copy link
Contributor Author

kratsg commented Feb 8, 2019

By not using clang for this check. I would run the check at run time as I suggested in #1315 (user should run a test job before submitting to grid anyways...) or somehow force the info switches to initialize at submission time.

I've tried to figure out a way to force info switches to initialize at submission time, but I cannot. So the easier way I've found is to do the parsing from within the xAH configuration instead -- but it won't be perfect since we can't handle all use-cases -- and this will only be used to check coverage.

Putting code in the header also increases compile time. Any class that includes the HelperFunctoins (aka any class) will have to recompile all this code.

I've fixed this now by creating a tempfile that's the concatenated inputs of the header/source and feeding that into Clang's single-file parser.

@kratsg
Copy link
Contributor Author

kratsg commented Feb 14, 2019

@kkrizka any updates? Should I merge this in?

@kkrizka
Copy link
Contributor

kkrizka commented Feb 15, 2019

Some things came up this week that I had to deal with urgently. But an alternative is on the way.

@kratsg kratsg deleted the branch master January 10, 2023 00:07
@kratsg kratsg closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants