Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup SIWT data structures #51

Merged
merged 17 commits into from
Jun 7, 2022
Merged

Setup SIWT data structures #51

merged 17 commits into from
Jun 7, 2022

Conversation

zengfung
Copy link
Collaborator

No description provided.

@zengfung zengfung linked an issue May 20, 2022 that may be closed by this pull request
Messy data structure of SIWPD #45
Open
@zengfung
Remove IndexAtTree from node data structure
e425b59 
Does not seem to have any purpose.
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022 •
edited
Loading

Codecov Report

Merging #51 (fa6e751) into dev (51baf49) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head fa6e751 differs from pull request most recent head e425b59. Consider uploading reports for the commit e425b59 to get more accurate results

@@            Coverage Diff             @@
##              dev      #51      +/-   ##
==========================================
- Coverage   98.29%   98.20%   -0.09%     
==========================================
  Files          27       27              
  Lines        3218     3014     -204     
==========================================
- Hits         3163     2960     -203     
+ Misses         55       54       -1
Impacted Files Coverage Δ
src/mod/ACWT.jl 96.51% <0.00%> (-0.24%) ⬇️
src/mod/SWT.jl 97.24% <0.00%> (-0.19%) ⬇️
src/mod/utils/utils_tree.jl 95.69% <0.00%> (-0.18%) ⬇️
src/mod/Utils.jl 97.26% <0.00%> (-0.13%) ⬇️
src/mod/utils/utils_dataset.jl 98.95% <0.00%> (-0.08%) ⬇️
src/mod/Visualizations.jl 99.15% <0.00%> (-0.06%) ⬇️
src/mod/ldb/ldb_measures.jl 98.86% <0.00%> (-0.05%) ⬇️
src/mod/BestBasis.jl 99.18% <0.00%> (-0.04%) ⬇️
src/mod/DWT.jl 100.00% <0.00%> (ø)
src/mod/LDB.jl 100.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51baf49...e425b59. Read the comment docs.

@zengfung
Copy link
Collaborator Author

zengfung commented Jun 5, 2022

SIWPD and best basis search with new data structure runs smoothly now. Signal reconstruction and documentation fixes are in progress.

@zengfung zengfung mentioned this pull request Jun 5, 2022
Open
@zengfung
Copy link
Collaborator Author

zengfung commented Jun 7, 2022

Signal reconstruction and documentation fixes complete.

@zengfung zengfung merged commit 76aa623 into UCD4IDS:dev Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Messy data structure of SIWPD
2 participants
@zengfung @codecov-commenter