Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mocking #86

Open
mattagape opened this issue Aug 31, 2018 · 1 comment
Open

Mocking #86

mattagape opened this issue Aug 31, 2018 · 1 comment
Labels
2018-19 Issues raised ahead of/during the 2018-19 teaching year

Comments

@mattagape
Copy link

  1. The links on this page don't activate as hyperlinks...the same Travis problem as earlier? I can't select any text on this page either.

  2. I don't think the Recording calls with mock section explains things properly. e.g. what is the side-effect part doing and why does function() throw an error?

  3. What's going on with MagicMock() - MagicMock()? It's not clear.

@ageorgou
Copy link
Contributor

ageorgou commented Sep 5, 2018

  • Using mocks to model test resources:
    • We could also mention that we want to mock processes that take a lot of time/resources, so that our tests are fast and cheap and can be run often
    • Will we have to replace this call to the Google API (and throughout the page) with another map API, or can we still use it (see problem in Issues with "An example Python data analysis notebook" page #58)?
    • (after map plot) "We can do this by mocking the request object": we're not really mocking an object; I'd say we're mocking the Google server.
  • The output cell after the patching is very long and does not scroll (same as in "Collaboration" page #79). Does this have something to do with the page not displaying correctly (no clicking or selecting)?
  • Testing functions that call other functions:
    • Formatting (mostly spaces around =)
    • I agree that this part is not clear. Perhaps we can say that the MagicMock is a more powerful mocking object that supports more operations?

@ageorgou ageorgou added the 2018-19 Issues raised ahead of/during the 2018-19 teaching year label Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2018-19 Issues raised ahead of/during the 2018-19 teaching year
Projects
None yet
Development

No branches or pull requests

2 participants