Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: should crash when finding N>2 fastq files #21

Open
1 task
e-t-k opened this issue Oct 2, 2018 · 0 comments
Open
1 task

Makefile: should crash when finding N>2 fastq files #21

e-t-k opened this issue Oct 2, 2018 · 0 comments

Comments

@e-t-k
Copy link
Contributor

e-t-k commented Oct 2, 2018

Weakness in current Makefile: as written will happily process the first R1 and R2 fastqs that it finds, ignoring any additional fastqs in dir that are found by the find command. This potentially results in a sample processed using only a subset of its reads, with no indication that anything is wrong.

If there are more than 2 valid fastqs, Makefile should instead crash. (Ideally, process them all; but that is not priority to implement as fab can take care of it.)

also minor cleanup:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant