Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in computing max profit over all forms #59

Closed
hanase opened this issue Jun 5, 2017 · 2 comments
Closed

Bug in computing max profit over all forms #59

hanase opened this issue Jun 5, 2017 · 2 comments
Assignees

Comments

@hanase
Copy link
Collaborator

hanase commented Jun 5, 2017

There is the same bug as in the public version of the model: When passing all forms (i.e. forms=None) into the developer model, the max profit is not computed. It's in _get_dataframe_of_buildings.

I submitted a PR fix for the previous version a while ago (still open):
UDST/urbansim#194

I probably cannot do a PR on a private repository without forking it to a public repository, so I won't.

@pksohn
Copy link
Contributor

pksohn commented Jun 5, 2017

Thanks Hana. I'll mimic the change from the PR on urbansim.

FYI, as far as I know, forking a private repo remains private by default in GitHub, and doesn't count against any kind of private repo quota: https://help.github.com/articles/about-forks/.

@pksohn pksohn self-assigned this Jun 5, 2017
@hanase
Copy link
Collaborator Author

hanase commented Jun 5, 2017

Thanks Paul! Good to know about the forking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants