Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwhitelist command #188

Merged
merged 6 commits into from
Dec 15, 2023
Merged

Unwhitelist command #188

merged 6 commits into from
Dec 15, 2023

Conversation

fattyhope
Copy link
Contributor

New command for the new UQCS Minecraft Server. The command will "unwhitelist" the user while simultaneously kicking them from the server.

Copy link
Member

@andrewj-brown andrewj-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I had no idea what you were working on, but this is a really useful PR. Got a couple changes, but they're all pretty minor; this will easily be mergeable tonight.

uqcsbot/minecraft.py Outdated Show resolved Hide resolved
uqcsbot/minecraft.py Outdated Show resolved Hide resolved
uqcsbot/minecraft.py Outdated Show resolved Hide resolved
uqcsbot/minecraft.py Outdated Show resolved Hide resolved
Copy link
Member

@andrewj-brown andrewj-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and merging. Couple extra things this PR has made me think of, but they're worth doing separately

@andrewj-brown andrewj-brown merged commit 3cc856b into UQComputingSociety:main Dec 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants