Skip to content
This repository has been archived by the owner on Aug 14, 2023. It is now read-only.

Peak Summary Rework #471

Open
lprivette opened this issue Feb 19, 2020 · 1 comment
Open

Peak Summary Rework #471

lprivette opened this issue Feb 19, 2020 · 1 comment

Comments

@lprivette
Copy link
Contributor

lprivette commented Feb 19, 2020

related to #389 and USGS-WiM/FEV#223

https://doimspp.sharepoint.com/:w:/r/sites/GS-UMidWIM/Shared%20Documents/Projects/STN/STNWeb/Peak%20Approvals.docx?d=w75a2c6ad3013435d9eeaf6c89bd7d3b2&csf=1&web=1&e=F6ROfO

This plan came out of the STN User Group discussion on 2/19.

https://doimspp.sharepoint.com/:x:/s/stnusergroup/EXZe52mtbhdGqmG235rCOUUBa0cYzzbkFm38QsBQ1cMuhw?email=lprivette%40usgs.gov&e=T7FPDf

Desired changes to STNWeb:

  • Approvals of peaks (Most important to them)
  • Indicate peak type both internally and to the public
    • Add peak_type drop down to peak submission form (ask Athena for authoritative names of the types)
    • Add eye public icon to the 'Peak Calculation Notes' in the form (we will be displayed in FEV on the data page)
    • They want to be able to add another summary for certain cases without having to close the Peak Summary form. Laura L and Steve H were vocal about want this if we need to understand this need more.

Changes that would be required on back end:

  • Would need to add a 'peak_type' field to the PeakSummaries endpoint and the FilteredPeaks view/endpoint (used in FEV)
    • I asked about back-filling the types for the existing peaks and they said it wasn't needed.

Other desires:
Need a descriptive/comment field associated with peak summaries that are associated with the peaks on the FEV. Need spot to assign some type of uncertainty associated with the WL data (ie, within +0.15 ft) when there are baseline shifts in data; or be able to correct as part of the scripts package.

@lprivette lprivette changed the title Peak Summary Refactor Peak Summary Rework Feb 19, 2020
@HansVraga
Copy link
Member

We've got multiple documents describing the changes to Peaks and approvals in STN. Need to start this effort by reviewing all of this material and creating a definitive plan of action.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants