Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change linting workflow to only check modified files #1601

Open
crd477 opened this issue Oct 22, 2024 · 2 comments
Open

Change linting workflow to only check modified files #1601

crd477 opened this issue Oct 22, 2024 · 2 comments

Comments

@crd477
Copy link
Contributor

crd477 commented Oct 22, 2024

I forget if this has come up before, so I'm creating an issue here for discussion.

Would it make sense to change the linting workflow to only run urlcheck on the files that were modified as part of a PR?

The motivation here is: we have a large and growing list of links to check in the content of our site. The urlcheck job already takes a long time to run. Checking every single link on the site for trivial changes seems... excessive. It also causes confusion for PR submitters when something they didn't touch fails the workflow, i.e., "hey, do I need to fix that expired job link to get my new event announcement merged???"

One upshot of the current method is that it provides a somewhat routine check for all the links and provides quick feedback to an attentive person. If we were to change the scope of the linting workflow, we should probably add a new cron-triggered workflow to urlcheck all the links on a periodic basis, maybe weekly or monthly, but then some group of people would need to be alert for failures.

Copy link
Contributor

Welcome to US-RSE! We are excited that this is your first issue!

@danielskatz
Copy link
Contributor

I don't think we've talked about this recently, though we certainly have in the past. I like the way this is now, for the reasons you say, but the alternative is also possibly good, if we can figure out who would be responsible for fixing problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants