Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questioun on Variable 'aff_threshold' and 'global_xyz_bounds' #5

Open
taeyunwoo opened this issue Nov 25, 2022 · 1 comment
Open

Questioun on Variable 'aff_threshold' and 'global_xyz_bounds' #5

taeyunwoo opened this issue Nov 25, 2022 · 1 comment

Comments

@taeyunwoo
Copy link

taeyunwoo commented Nov 25, 2022

Hello, I'm trying to add a new primitive types on your code.
Before questions, I'm really appreciate your work! Thanks a lot.

Anyway, I cannot understand the 'aff_threshold' and 'global_xyz_bounds'.
As I read the paper, 'aff_threshold' variable may be used when the network chooses a proper primitive with softmax returned value.
However, 'reach' primitive does not have an 'aff_threshold' variable. Does it use base_config's aff_threshold?
Also, the skill 'open' (Gripper Release) information was not in skill_config. Where can I see its code?

To 'global_xyz_bounds' as I guessed, 'global_xyz_bounds' may be the threshold of checking primitives in the network. Is it right?

Thank you for reading this questions.

@humphreyde
Copy link

Hi, I have the same problem with you. Have you solved it? Since I have changed robot and the position of object such as peg in PegInHole, I'm not sure if I need to change position_limits or aff_threshold in env_params. I would appreciate for your reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants