Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of freedom-for-uproxy* #428

Closed
willscott opened this issue Oct 2, 2014 · 9 comments
Closed

Remove use of freedom-for-uproxy* #428

willscott opened this issue Oct 2, 2014 · 9 comments
Labels

Comments

@willscott
Copy link
Member

freedom-for-uproxy-for-* is detrimental for a couple reasons:

  • internal changes to the build process can't be upgraded, so you can't take advantage of our fixes to security bugs like UP-01-003 Worker-based Isolation does not prevent XHR & Sockets etc. #365
  • Large amounts of code outside of sandboxes widen the trusted code base, and create more potential for attacks
  • Destandardization means that uproxy becomes more tightly tied to specific browsers and increases the work for building implementations for new platforms.
@willscott willscott self-assigned this Oct 2, 2014
@trevj trevj added the P2 label Oct 3, 2014
@trevj
Copy link
Contributor

trevj commented Oct 3, 2014

I would like to remove all this too but I would say doing so depends on:
#315

@iislucas
Copy link
Contributor

Steps to do this:

  • Write lightweight WebRTC core provider
  • Rewrite peer-connection in terms of lightweight provider
  • Merge custom logging code and freedom code logger.

Reasons to do this:

  • To use new freedom testing infrastructure from freedom we need to be on freedom 0.6
  • Freedom 0.6 would need to drop our custom core-provider.

@iislucas iislucas added this to the v2.0 Baxter release (After v1.0 Allardice launch) milestone Oct 13, 2014
@willscott
Copy link
Member Author

Are you claiming you're not going to have integration tests until after launch? How are you planning to test end-to-end stability?

I'd also add that you don't have a way to do storage in firefox before v0.6, or a way to record freedom.js logs, both of which seem pretty essential.

@iislucas
Copy link
Contributor

We need integration tests for uproxy 0.6; if that means we need freedom 0.6, then we need to do this. I'd like to it done soon as we can after freedom 0.6 is fully functional.

@iislucas iislucas added P1 and removed P2 labels Oct 13, 2014
@iislucas iislucas modified the milestones: v0.6 Allardice (Web Store Feature Complete), v2.0 Baxter release (After v1.0 Allardice launch) Oct 13, 2014
@iislucas iislucas assigned trevj and unassigned willscott Oct 27, 2014
@iislucas
Copy link
Contributor

Now in progress by @trevj and @bemasc

@trevj
Copy link
Contributor

trevj commented Nov 11, 2014

Getting closer! Version 15 of uproxy-lib uses freedom.js 0.6 which eliminates freedom-for-uproxy*. Still working on the other repos...

@willscott
Copy link
Member Author

Should be completed in #638

@dborkan
Copy link
Contributor

dborkan commented Dec 16, 2014

Can this be closed now? Or does Firefox work still remain?

@salomegeo
Copy link
Collaborator

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants