Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed routes does not work on swap page #5

Open
muhammedea opened this issue Oct 12, 2024 · 2 comments
Open

Mixed routes does not work on swap page #5

muhammedea opened this issue Oct 12, 2024 · 2 comments
Labels
bug Something isn't working Scouts Game - Epic

Comments

@muhammedea
Copy link

muhammedea commented Oct 12, 2024

When swap path is calculated if there are possible V2 and V3 pools, mixed router system is not working. Seems there is a bug in the smart-order-router. This should be debugged and fixed. Also V2 pool list should be coming from backend.

@muhammedea muhammedea added bug Something isn't working Scouts Game - Epic labels Oct 12, 2024
@pbkompasz
Copy link

@muhammedea Can you share the swaps where the router is not working properly?

@muhammedea
Copy link
Author

@pbkompasz we use smart-order-router for the path calculation. It is located in the packages directory. That code is taken from the original uniswap/smart-order-router on the May 2024.
For testing, swapping USDGLO for mcUSD can be used. It says insufficient liquidity. But it is possible by mixed route. In v2 there is a pool for mcUSD-CELO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Scouts Game - Epic
Projects
None yet
Development

No branches or pull requests

2 participants