Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components sandbox / playground #68

Open
anbalase opened this issue Jan 8, 2020 · 4 comments
Open

Components sandbox / playground #68

anbalase opened this issue Jan 8, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@anbalase
Copy link
Collaborator

anbalase commented Jan 8, 2020

Based on @vladjerca's suggest sandbox setup 496fde7 expand for all components

@anbalase anbalase added the enhancement New feature or request label Jan 8, 2020
@vladjerca
Copy link
Contributor

@anbalase @mhagape I think we could use storybook to document usage and display the rendered results.

All our libs are going this direction and it would be great if we could add this to the gh_pages. Maybe drop compodoc?

@sergiubologa
Copy link
Member

@anbalase @mhagape I think we could use storybook to document usage and display the rendered results.

All our libs are going this direction and it would be great if we could add this to the gh_pages. Maybe drop compodoc?

We tried here in Cluj to make Storybook work with the lib and it didn't work quite well. We couldn't make it work properly. I didn't invest too much time, maybe you'll have more luck.

@vladjerca
Copy link
Contributor

@sergiubologa Was it because of the pdf-js web worker or what exactly was the issue?

@sergiubologa
Copy link
Member

@sergiubologa Was it because of the pdf-js web worker or what exactly was the issue?

Not really. Mainly it was because the DI doesn't seem to work with Storybook and I couldn't find a quick solution for it. Maybe the upgrade to Angular 9 will fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants