Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate using Travis for Windows builds #204

Open
lassik opened this issue Oct 12, 2018 · 13 comments
Open

Evaluate using Travis for Windows builds #204

lassik opened this issue Oct 12, 2018 · 13 comments

Comments

@lassik
Copy link
Contributor

lassik commented Oct 12, 2018

From the Travis CI blog: Windows is Available (Early Release) Oct 11, 2018

Found by @stevenzeck

@stevenzeck
Copy link
Contributor

stevenzeck commented Oct 12, 2018

To Do:

  • Add windows to the os list
  • Don't download/configure CodeClimate or send test results when running Windows builds as it is not supported
  • Configure so all OS's use LF and not CRLF. When cloning a repo and checking out a commit, the linebreaks depend on the OS, so Windows builds will fail TSLint since it uses CRLF and not LF. I'm playing around by adding a .gitattributes file with * text=auto eol=lf.

@stevenzeck
Copy link
Contributor

stevenzeck commented Oct 12, 2018

Seems to be working in beautifier-eslint:

@lassik
Copy link
Contributor Author

lassik commented Oct 12, 2018

Awesome 🎉 The eslint Windows builds seem to be red, but only because of the CRLF situation.

@stevenzeck
Copy link
Contributor

It's red on the PR build, not the branch build.

@lassik
Copy link
Contributor Author

lassik commented Oct 12, 2018

What's different between them? The commit hash is the same.

@stevenzeck
Copy link
Contributor

I'll try pushing everything as one commit and see if that makes a difference. Otherwise I think one is a standard commit while the other is a merge commit.

@lassik
Copy link
Contributor Author

lassik commented Oct 13, 2018

The outcome seems to be the same :/ I just had a weird incident too, where something worked in Travis in a branch but not in a PR: Unibeautify/beautifier-clang-format#81

@lassik
Copy link
Contributor Author

lassik commented Oct 13, 2018

BTW, should Code Climate be run separately for each platform, or is it enough to run it on Linux only?

@stevenzeck
Copy link
Contributor

It shouldn't matter. All it does it reports the coverage results of npm test (I think all repos use that command) from Travis to CodeClimate, not much overhead.

@lassik
Copy link
Contributor Author

lassik commented Oct 16, 2018

Ah, that makes sense. For reference, the Code Climate reporter is not available (pre-built) for Windows, only Linux and OSX: https://docs.codeclimate.com/v1.0/docs/configuring-test-coverage#section-locations-of-pre-built-binaries

@stevenzeck
Copy link
Contributor

Yep, that's the second checkmark #204 (comment)

@lassik
Copy link
Contributor Author

lassik commented Oct 16, 2018

Sorry, missed that one.

@Glavin001
Copy link
Member

👍I would greatly prefer Travis CI to AppVeyor.

Let me know if you need anything from me. Sounds like you already have a plan and are making this a reality 🎉 ! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants