Remove unused setuptools config #3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools property is unused in pyproject. Config zip-safe, platforms not needed, and src was being auto-discovered by setuptools since where was incorrectly specified.
dcamron
added
Area: Infrastructure
dopplershift
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Good catch. I had no idea zip-safe was essentially pointless after eggs (which is all of MetPy's modern development history).
Also, where was done to make sure tests didn't end up in the wheel, but it looks like the auto detection is doing precisely the correct thing (I built locally) so I'm happy to go with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tools(as opposed totool) table is not valid inpyproject.toml. Doesn't look like we'd gain anything from correctly specifyingzip-safeandplatforms.setuptools was also automatically discovering our project layout since
wherewas inappropriately considered. I've removed all these; I'm glad to re-addwherecorrectly if we feel the explicitness helps.